[Feature] Add MorphToMany support #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attach MorphToMany working detaching works sync working cleanup
# Conflicts: # tests/RelationsTest.php
hans-thomas
commented
Nov 16, 2023
Comment on lines
+36
to
+40
| /** @inheritdoc */ | ||
| public function getRelationExistenceQuery(Builder $query, Builder $parentQuery, $columns = ['*']) | ||
| { | ||
| return $query; | ||
| } |
There was a problem hiding this comment.
I think the parent method is fine and we don't need to override this. I will write test for this too.
There was a problem hiding this comment.
This one is related to HybridRelations and never called in my tests.
We don't need this method anymore;
This reverts commit 5d229eb.
hans-thomas
commented
Nov 18, 2023
Comment on lines
-117
to
+125
| $relations = $hasQuery->pluck($this->getHasCompareKey($relation)); | ||
| $relations = match (true) { | ||
| $relation instanceof MorphToMany => $relation->getInverse() ? | ||
| $this->handleMorphedByMany($hasQuery, $relation) : | ||
| $this->handleMorphToMany($hasQuery, $relation), | ||
| default => $hasQuery->pluck($this->getHasCompareKey($relation)) | ||
| }; |
There was a problem hiding this comment.
I added a match expression to handle the MorphToMany relations has query.
alcaeus
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Just a minor comment. Thanks for working on this @hans-thomas, and I really appreciate the amount of comments you added to the code! ❤️
|
@alcaeus My pleasure❤️ |
Co-authored-by: Andreas Braun <alcaeus@users.noreply.github.com>
GromNaN
reviewed
Nov 21, 2023
|
|
||
| if ($this->getInverse()) { | ||
| // Attach the new ids to the parent model. | ||
| $this->parent->push($this->table, [ |
There was a problem hiding this comment.
Great 👍🏻 It seems that you have tested this case carefully.
Co-authored-by: Jérôme Tamarelle <jerome@tamarelle.net>
Co-authored-by: Jérôme Tamarelle <jerome@tamarelle.net>
GromNaN
approved these changes
Nov 22, 2023
|
Thank you so much @hans-thomas |
|
@GromNaN I'm glad I could help❤️ |
Treggats
pushed a commit
to Treggats/laravel-mongodb
that referenced
this pull request
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I continued #2640 PR, thanks to @ithuis. I fixed the relationship and its inverse way,
but it still needs more tests for
attachinga collection of modelsdetachingactionsyncingactionloadmethodIt has to be done by tomorrow.