Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method Connection::ping() to check server connection #2677

Merged
merged 7 commits into from Nov 13, 2023

Conversation

hans-thomas
Copy link
Contributor

@hans-thomas hans-thomas commented Nov 13, 2023

Hi, due to the provided solution in #2649, I added a new method on the Connection.php to make it easy for users to access it.

@hans-thomas hans-thomas marked this pull request as ready for review November 13, 2023 12:45
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's great, with a little cleanup.

src/Connection.php Outdated Show resolved Hide resolved
src/Connection.php Outdated Show resolved Hide resolved
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

tests/ConnectionTest.php Outdated Show resolved Hide resolved
src/Connection.php Outdated Show resolved Hide resolved
@GromNaN GromNaN changed the title Ping method in Connection.php Add method Connection::ping() to check server connection Nov 13, 2023
@GromNaN GromNaN changed the title Add method Connection::ping() to check server connection Add method Connection::ping() to check server connection Nov 13, 2023
@GromNaN GromNaN merged commit 1b7b5e4 into mongodb:4.1 Nov 13, 2023
13 checks passed
@GromNaN
Copy link
Member

GromNaN commented Nov 13, 2023

Thank you @hans-thomas

@hans-thomas hans-thomas deleted the 2649-ping-method branch November 13, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants