Add test for the $hidden property
#2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
requested changes
Nov 27, 2023
GromNaN
reviewed
Nov 27, 2023
tests/Models/Animal.php
Outdated
| * @method static Builder truncate() | ||
| * @method static Eloquent sole(...$parameters) | ||
| */ | ||
| final class Animal extends Eloquent |
There was a problem hiding this comment.
I don't see what is tested with this model class. Hidden fields and the toArray feature are tested with HiddenAnimal.
There was a problem hiding this comment.
The idea of the two classes is that one has the hidden property and another doesn't. As to prove the working of the hidden property.
Or do you suggest to have one class and use different fields to test?
There was a problem hiding this comment.
IMHO, the test on HiddenAnimal already covers the feature.
There was a problem hiding this comment.
Fair enough, will remove this class and its usage
Treggats
commented
Nov 27, 2023
Co-authored-by: Andreas Braun <alcaeus@users.noreply.github.com>
Treggats
commented
Nov 27, 2023
GromNaN
approved these changes
Nov 27, 2023
alcaeus
approved these changes
Nov 30, 2023
|
Thank you @Treggats |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #1119
closes #1119
This adds a test which covers the working of the
$hiddenproperty.