Build fixes for MSVC. #135
Conversation
xpol
commented
Jul 9, 2015
xpol
commented
- Disable UTF-8 related test for MSVC, it just don't support UTF-8.
- VS 2015 has snprintf()
- VS 2015 removed _set_output_format()
- VS 2015 defines timespec.
1. VS 2015 has snprintf() 2. VS 2015 removed _set_output_format() 3. VS 2015 defines timespec.
|
How is the UTF-8 tests failing? That seems like a major issue if you can insert a key with UTF-8, but cannot read it back. What does 'str' contain in the tests/test-json.c test for example? |
|
visual studio can't compile string literals contains non-ascii characters. |
|
I should say "Disable tests that contains non ascii string literals, visual studio can't process them." |
|
Thanks for the contribution, we're going to merge the _set_output_format and timespec fixes (with some modifications). I don't understand why you need to ifdef-out the UTF-8 tests, however. With our VS2015 build system we can compile and run those tests in test-bson.c and test-json.c. Can you show us the error message? What precise version of Windows and Visual Studio are your running, please? |
|
Merged in 4fb312c. |
|
Sorry, I have no Windows PC now. |
|
OK we'll replace the UTF-8 symbols with escape sequences: https://jira.mongodb.org/browse/CDRIVER-1003 |
|
The UTF-8 issue is fixed in d4feba4. |
|
👍 |
