MONGOCRYPT-340 add macOS m1 variant #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expect all bindings tasks to fail. But the logs may be useful for other developes.
kevinAlbs
changed the title
kevinAlbs
changed the title
addaleax
approved these changes
Jan 14, 2022
nbbeeken
approved these changes
Jan 14, 2022
|
LGTM. In agreement with @nbbeeken on the follow up work. |
durran
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
macos_m1running on distromacos-1100-arm64to run the taskbuild-and-test-and-upload./opt/homebrew/bin/cmakeinstead of/Applications/Cmake.app/Contents/bin/cmake. The former hasarm64architecture and producesarm64builds by default. The latter hasx86_64architecture and builds withx86_64architecture by default. See BUILD-14565.Caveats
Bindings tasks, like
build-and-test-node,build-and-test-java,build-and-test-csharp, andtest-pythonwill require further changes. This Evergreen patch build is configured with all tasks and should provide error logs.The linked patch build includes a failing
build-and-test-nodeon Windows 2016. I think it is unrelated to these changes.