-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PYTHON-4181 Use libmongocrypt native crypto when available for 10-50x better performance #756
Conversation
… performance Bundle crypto-enabled libmongocrypt on Mac and Windows.
…all examples to prefer crypto-enabled builds
Need to address this problem on macOS <=10.14:
@kevinAlbs more generally, how can we be sure all crypto functions are supported when mongocrypt_is_crypto_available() returns True? |
The error
libmongocrypt tests check the version of macOS. Perhaps do a similar check in Python? |
Thanks, since this isn't just a test issue I've opted to always register the CTR crypto callbacks on macOS < 10.15 (mongocrypt_setopt_aes_256_ctr) even when mongocrypt_is_crypto_available is True. This seems to work fine. Could you confirm it's supported to selectively register crypto callbacks like this? |
I expect "yes". Filed MONGOCRYPT-647 to add tests within libmongocrypt to guarantee this behavior. |
Thanks all! |
PYTHON-4181 Use libmongocrypt native crypto when available for better performance
TODO:
Before:
After (10-50x higher throughput):