Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing ssize_t #89

Closed
wants to merge 1 commit into from
Closed

Fix missing ssize_t #89

wants to merge 1 commit into from

Conversation

andypost
Copy link

@andypost andypost commented Feb 4, 2020

I'm trying to package PHP mongo 1.7.0 for Alpinelinux but getting error on build

 In file included from /builds/andypost/aports/testing/php7-pecl-mongodb/src/mongodb-1.7.0/src/libmongocrypt/kms-message/src/kms_kv_list.h:21,
                  from /builds/andypost/aports/testing/php7-pecl-mongodb/src/mongodb-1.7.0/src/libmongocrypt/kms-message/src/kms_kv_list.c:18:
 /builds/andypost/aports/testing/php7-pecl-mongodb/src/mongodb-1.7.0/src/libmongocrypt/kms-message/src/kms_request_str.h:42:52: error: unknown type name 'ssize_t'; did you mean 'size_t'?
    42 | kms_request_str_new_from_chars (const char *chars, ssize_t len);
       |                                                    ^~~~~~~
       |                                                    size_t
 /builds/andypost/aports/testing/php7-pecl-mongodb/src/mongodb-1.7.0/src/libmongocrypt/kms-message/src/kms_request_str.h:44:36: error: unknown type name 'ssize_t'; did you mean 'size_t'?
    44 | kms_request_str_wrap (char *chars, ssize_t len);
       |                                    ^~~~~~~
       |                                    size_t
 /builds/andypost/aports/testing/php7-pecl-mongodb/src/mongodb-1.7.0/src/libmongocrypt/kms-message/src/kms_request_str.h:56:28: error: unknown type name 'ssize_t'; did you mean 'size_t'?
    56 |                            ssize_t len);
       |                            ^~~~~~~
       |                            size_t
 /builds/andypost/aports/testing/php7-pecl-mongodb/src/mongodb-1.7.0/src/libmongocrypt/kms-message/src/kms_request_str.h:66:31: error: unknown type name 'ssize_t'; did you mean 'size_t'?
    66 |                               ssize_t len);
       |                               ^~~~~~~
       |                               size_t
 /bin/sh /builds/andypost/aports/testing/php7-pecl-mongo

@andypost
Copy link
Author

andypost commented Feb 4, 2020

btw it fails only when I build with openssl

WIP in https://gitlab.alpinelinux.org/alpine/aports/merge_requests/3708

/cc @fabiorphp

@blackkopcap
Copy link

@fabiorphp, When it can be merged?

@danizord
Copy link

Pinging @faabiosr as the account was moved :)

@kevinAlbs
Copy link
Contributor

Thank you for the contribution, and apologies for not seeing this sooner. This was fixed in the most recent patch release (1.0.2) in the following commit: 90ce62d

@kevinAlbs kevinAlbs closed this Feb 11, 2020
@nefethael
Copy link

Hi @kevinAlbs,

Don't we need to upgrade mongodb mongo/src/third_party/kms-message/ with latest 1.0.2 then?

Best regards,
Vincent

@kevinAlbs
Copy link
Contributor

Hi @nefethael,
Yes that seems reasonable. It may not be as urgent for the MongoDB server to upgrade its copy of kms-message, since it is primary distributed as a binary. But users compiling the server from source would encounter the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants