CDRIVER-4484 Address -Wformat and -Wstrict-prototypes warnings

[eramongodb]

Description

This PR resolves CDRIVER-4484 by addressing -Wformat=2 and -Wstrict-prototypes warnings.

Warnings were detected using GCC 12.1.0 and Clang 10.0.0 on Ubuntu 20.04 and GCC 12.1.0 (mingw-w64) on Windows with ENABLE_CLIENT_SIDE_ENCRYPTION=(OFF|ON) and ENABLE_TRACING=(OFF|ON).

[vector-of-bool]

LGTM, but can we add these warnings to somewhere that they will appear again? i.e. maintainer-flags or MongoC-Warnings.cmake?

[eramongodb]

can we add these warnings to somewhere that they will appear again?

-Wformat=1 is already enabled implicity via -Wall according to GCC Options documentation, which is already enabled when building on Linux and MacOS distros (ENABLE_MAINTAINER_FLAGS=ON -> maintainer-flags.txt). I do not think any of the instances that were reported required -Wformat=2.

Most of these warnings have escaped noticed due to requiring:

1. ENABLE_TRACING=ON, which is only done for the compile-tracing task run on Ubuntu 18.04), and
2. compiling Windows code paths with GCC (i.e. MinGW), as MSVC does not have -Wformat.

This may be an argument for adding the compile-tracing task to more variants such as Windows. I will consider doing so when working on CDRIVER-3620.

As for -Wstrict-prototypes, it seems to be a hit-or-miss when testing with Clang. Testing with GCC uncovered a few more instances. Still, I think it is safe to add to the set of maintainer flags. Filed CDRIVER-4504 as followup work.

[jeroen]

Which release would this be included in? I noticed it hasn't been included in 1.23.1 and 1.22.2

[eramongodb]

@jeroen As documented in CDRIVER-4484, this is scheduled to be included in the upcoming 1.24.0 release.