CDRIVER-4454 add integration tests for Azure KMS #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And regenerate config.yml
kevinAlbs
changed the title
.evergreen/config.yml
Outdated
| set -o errexit | ||
| # TODO: update once https://github.com/mongodb-labs/drivers-evergreen-tools/pull/239 is merged. | ||
| git clone https://github.com/kevinAlbs/drivers-evergreen-tools.git --branch DRIVERS-2411 drivers-evergreen-tools | ||
| DRIVER_TOOLS=$(pwd)/drivers-evergreen-tools |
There was a problem hiding this comment.
Done. DRIVERS_TOOLS is consistent with other naming in the config.
.evergreen/config.yml
Outdated
| export AZUREKMS_RESOURCEGROUP=${testazurekms_resourcegroup} | ||
| export AZUREKMS_VMNAME=${AZUREKMS_VMNAME} | ||
| export AZUREKMS_PRIVATEKEYPATH=/tmp/testazurekms_privatekey | ||
| DRIVER_TOOLS=$(pwd)/drivers-evergreen-tools |
There was a problem hiding this comment.
nit: If I understand this code correctly, this looks unnecessary if you use DRIVERS_TOOLS env variable
There was a problem hiding this comment.
DRIVERS_TOOLS is not defined before in this task.
| export AZUREKMS_RESOURCEGROUP=${testazurekms_resourcegroup} | ||
| export AZUREKMS_VMNAME=${AZUREKMS_VMNAME} | ||
| export AZUREKMS_PRIVATEKEYPATH=/tmp/testazurekms_privatekey | ||
| DRIVERS_TOOLS=$(pwd)/drivers-evergreen-tools |
There was a problem hiding this comment.
NOTE: if you use DRIVERS_TOOLS, this value should already be assigned, at least this is what I saw in the c# driver (same in other places)
There was a problem hiding this comment.
Missed your explanation above. It's a bit strange, but ok :)
galon1
approved these changes
Oct 25, 2022
vector-of-bool
requested changes
Nov 1, 2022
vector-of-bool
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Here is an Evergreen patch build with the new tasks: https://spruce.mongodb.com/version/63500fcbd1fe071dfc2682da/
Notes
The additions to the Python evergreen generation scripts are minimal. IMO the Python scripts are not significantly more readable than the Evergreen config YML. For this PR, I found it easier to start with Evergreen YML, then translate to the Python scripts.