mongoc_bulk_operation_execute: ensure reply is initialized before returning #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, we'll merge in the next few days. |
|
Tracking in https://jira.mongodb.org/browse/CDRIVER-1433 |
|
Merged in 0e0ae00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for "mongoc_bulk_operation_execute" says "reply is always initialized, even upon failure. Callers must call bson_destroy() to release this potential allocation."
However, implementation does not initialize reply in all cases, making it impossible for the caller to determine whether reply has been initialized or not. This is contrary to documentation, which says that reply is ALWAYS initialized.
This commit changes the implementation to be in accordance with the documentation. reply is initialized before any return.