Fixing gridfs_file_set_xxx wouldn’t export to module map. #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using clang to export modules, functions set of mongo_gridfs_file_set_xxx couldn’t export to destination simply because only the getting methods were marked with BSON_API. Typical scenario is a third party exporting, such as c library exporting for Swift language. Script test-libmongoc, which includes GridFS, passed. This issue was found by Kyle Jessup and Rockford Wei, perfect.org
|
Awwman. Excellent catch, thank you |
|
You are very welcome, hope this bug could be fixed in the incoming releases. |
|
I made a jira ticket for tracking this issue https://jira.mongodb.org/browse/CDRIVER-1971 and make sure it'll be in our next release |
|
Thank you & Happy New Year! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using clang to export modules, functions set of
mongo_gridfs_file_set_xxx couldn’t export to destination simply because
only the getting methods were marked with BSON_API. Typical scenario is
a third party exporting, such as c library exporting for Swift
language.
Script test-libmongoc, which includes GridFS, passed.
This issue was found by Kyle Jessup and Rockford Wei,
perfect.org