CSHARP-4684: Make part of IMongoQueryProvider public. #1325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to solve an issue Damien was having getting the
LoggedStages
in the EF Core Provider in some cases.Our earlier work made
LoggedStage
available via theIMongoQueryable
interface. But when executing "scalar" (single valued) LINQ queries the EF Core Provider callsExecute
directly on the internalIMongoQueryProvider
.Damien was having to use reflection to call the
LoggedStages
property on theIMongoQueryProvider
.This PR is a proposal to make part of the
IMongoQueryProvider
interface public by splitting the interface into public and internal parts.I also made the
ExecuteAsync
method public. Damien, you are already calling theExecute
method (defined inIQueryProvider
), do you not need to callExecuteAsync
to handle async queries? Or does EF Core not support async queries?For purposes of looking at this together I just used the existing CSHARP-4684 ticket. We may choose to create a new ticket.