feat: add majority with journaled option on write concern option

[jinwoo1225]

Summary

Add WriteConcern Option MajorityWithJournaled to explicitly sets write majority with journaled write.

Background & Motivation

To explicitly use write majority with journaled option on mongo go driver package we have to use like this.

but using two option into one struct seems awkward to me. So I propose MajorityWithJounaled function to use both option at once.

writeConcern := &writeconcern.WriteConcern{
	W:       writeconcern.Majority().W,
	Journal: writeconcern.Journaled().Journal,
}

[matthewdale]

Hey @jinwoo1225 thanks for the PR! I have a few questions:

1. What is your use case for explicitly enabling journaling? Typically write concern majority defaults to journaling enabled unless it's disabled by writeConcernMajorityJournalDefault.
2. How often do you declare write concerns? If it's not often, would an alternative like this work?

writeConcern := writeconcern.Majority()
j := true
writeConcern.Journal = &j

[jinwoo1225]

Hello! @matthewdale Thank you for your response. and sorry for my late reply.

1. I explicitly enabled journaling in my MongoDB configuration to ensure data durability and prevent data loss in the event of unexpected crashes or failures. While I understand that write concern majority generally defaults to journaling enabled, I wanted to explicitly specify it in my use case for added data safety and consistency.
2. Mostly, I declare write concerns once for specific collection configurations in our application. For this purpose, I use code snippets like the following in codeblock.

writeConcern := &writeconcern.WriteConcern{
	W:       writeconcern.Majority().W,
	Journal: writeconcern.Journaled().Journal,
}

[matthewdale]

Hey @jinwoo1225, thanks for the additional context! Your concern about the awkward API is definitely valid. However, I don't think that adding convenience functions for more permutations of write concerns configs is a sustainable pattern. Instead, we should find a more usable way to enable journaling for any write concern and make defining struct literals for the "majority" write concern easier.

I've created GODRIVER-2953 to request an improved API for enabling journaling on write concerns and GODRIVER-2954 to request an improved way to define write concern "majority" struct literals.

Closing this PR.

[jinwoo1225]

Thank you for your attention to this pull request. I'm delighted to see an enhanced version of it. 😄