Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2978 Automate syncing code between Go driver v1 and v2 #1391

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

blink1073
Copy link
Member

GODRIVER-2978

Summary

Help automate syncing between the v1 branch and master, which is targeting v1.

Background & Motivation

Help make the v2 transition smoother.

Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Alternatively, could an existing action like https://github.com/marketplace/actions/sync-branches work as well?

sha=$1
base=v1
target=master
dirname="/tmp/go-driver-$(openssl rand -hex 12)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: Consider using mktemp -d instead, which honors the temp dir on different OSes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@blink1073
Copy link
Member Author

Updated to use our own action, since github.com/marketplace/actions/sync-branches is unmaintained, and this allows us to use the same script locally when needed.

Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@blink1073 blink1073 merged commit 8d10a9e into mongodb:v1 Sep 25, 2023
1 check failed
prestonvasquez added a commit to prestonvasquez/mongo-go-driver that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants