GODRIVER-3240 Replace all bit-shifting in wiremessage with encoding/binary calls. #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change ReportNo changes found! |
matthewdale
force-pushed
the
experiment-use-binary-in-wm
branch
from
b212180
to
f5b7c10
Compare
matthewdale
changed the title
matthewdale
commented
Jun 8, 2024
| @@ -1865,7 +1865,6 @@ func (op Operation) decodeResult(opcode wiremessage.OpCode, wm []byte) (bsoncore | |||
| return nil, errors.New("malformed wire message: insufficient bytes to read single document") | |||
| } | |||
| case wiremessage.DocumentSequence: | |||
| // TODO(GODRIVER-617): Implement document sequence returns. | |||
There was a problem hiding this comment.
This comment appears stale and references a GODRIVER ticket that is "Done", so I removed it.
blink1073
pushed a commit
to blink1073/mongo-go-driver
that referenced
this pull request
Jun 10, 2024
…inary calls. (mongodb#1646) (cherry picked from commit ab38b74)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3240
Summary
"encoding/binary"package instead of custom bit-shifting logic to convert between binary and integer values in thewiremessagepackage.wiremessagefunctions.Background & Motivation