-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GODRIVER-1844 export unified test runner #607
Conversation
@iwysiu There's a number of test failures in the linked patch build. Can you look into those before we review? |
Should be fixed! As a note, I suspect that there will be further changes for the atlas planned maintenance stuff, but I figured this was a big enough change to get looked at on its own. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just to clarify, we do want to export integration/unified/unified_spec_test
and not integration/unified_spec_test
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain how the planned maintenance test runner provides test files to run? Does it give you one filepath at a time, a path to a directory of files, or something else?
The test runner guide says "json blob" but it looks to me like the ruby implementation reads a file |
All of the functions that were not calling the runner were made private. Notes: