Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-1844 export unified test runner #607

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Conversation

iwysiu
Copy link
Contributor

@iwysiu iwysiu commented Mar 10, 2021

All of the functions that were not calling the runner were made private. Notes:

  1. matches_test.go got broken up into its functions and its test
  2. Some of the variables in EntityMap were renamed to avoid collisions between the variables and the now unexported functions.

@divjotarora
Copy link
Contributor

@iwysiu There's a number of test failures in the linked patch build. Can you look into those before we review?

@iwysiu
Copy link
Contributor Author

iwysiu commented Mar 11, 2021

@iwysiu There's a number of test failures in the linked patch build. Can you look into those before we review?

Should be fixed! As a note, I suspect that there will be further changes for the atlas planned maintenance stuff, but I figured this was a big enough change to get looked at on its own.

Copy link
Contributor

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just to clarify, we do want to export integration/unified/unified_spec_test and not integration/unified_spec_test, right?

Copy link
Contributor

@divjotarora divjotarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain how the planned maintenance test runner provides test files to run? Does it give you one filepath at a time, a path to a directory of files, or something else?

@iwysiu
Copy link
Contributor Author

iwysiu commented Mar 16, 2021

Can you explain how the planned maintenance test runner provides test files to run? Does it give you one filepath at a time, a path to a directory of files, or something else?

The test runner guide says "json blob" but it looks to me like the ruby implementation reads a file

@iwysiu iwysiu requested a review from divjotarora March 17, 2021 16:30
@iwysiu iwysiu merged commit b7f9264 into mongodb:master Mar 17, 2021
divjotarora pushed a commit to divjotarora/mongo-go-driver that referenced this pull request Mar 18, 2021
divjotarora pushed a commit to divjotarora/mongo-go-driver that referenced this pull request Mar 18, 2021
divjotarora pushed a commit to divjotarora/mongo-go-driver that referenced this pull request Mar 18, 2021
faem pushed a commit to kubedb/mongo-go-driver that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants