GODRIVER-2154 Audit code generated by operationgen and remove operationgen #809
Conversation
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); you may | ||
| // not use this file except in compliance with the License. You may obtain | ||
| // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
hello.go was missing a license for some reason (the reason being I made the file and forgot to add the license).
There was a problem hiding this comment.
What's the general procedure deciding when a file should have a license? I'm not super familiar with licensing open source software but it seems pretty important to ensure it's being used the way we expect it to.
There was a problem hiding this comment.
A great question hahah. I'm also not super familiar with our licensing policy, but this copyright notice should probably appear in every file written by us and available to users of the repo. We're certainly missing the copyright on some files (here's just one example). If it's important for us to have copyright on every file, I can file a ticket for auditing the code base (@kevinAlbs).
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); you may | ||
| // not use this file except in compliance with the License. You may obtain | ||
| // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
What's the general procedure deciding when a file should have a license? I'm not super familiar with licensing open source software but it seems pretty important to ensure it's being used the way we expect it to.
GODRIVER-2154
The Go driver used to rely on an internal code generation tool called
operationgento create the operation-specific files underx/mongo/driver/operation. We no longer rely on this tool and now edit these files by hand.This PR does a number of things:
build[type]Resultfunctions in operations underx/mongo/driver/operationand correctly returns errors (fixes a number of bugs created by a faultyoperationgentemplate).// Code generated by operationgen. DO NOT EDIT.notes at the top of files inx/mongo/driver/operation.*.tomlfiles inx/mongo/driver/operation.cmd/operationgenandx/mongo/driver/drivergen.x/mongo/driver/operationin.golangci.yml.The
operationgenalso used a dependency calledpackrthat I believe we can now remove. To avoid bloating this PR, I've filed GODRIVER-2234 to do that separately.