Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2315 Further restrict tests that expect errors with capped collection deletes. #930

Merged
merged 1 commit into from
May 2, 2022
Merged

GODRIVER-2315 Further restrict tests that expect errors with capped collection deletes. #930

merged 1 commit into from
May 2, 2022

Conversation

benjirewis
Copy link
Contributor

GODRIVER-2315

SERVER-63201 recently allowed deletes on capped collections in the latest server versions. That ticket was backported to server version 5.0.7. Some of our tests in integration/collection_test.go expect server-side write errors when running a delete operation against a capped collection. Updates these tests to only run against 5.0.6- (previously ran on 5.2.99-).

Copy link
Collaborator

@prestonvasquez prestonvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@benjirewis benjirewis merged commit e61044a into mongodb:master May 2, 2022
@benjirewis benjirewis deleted the newCappedCollDeletes.2315 branch May 2, 2022 17:29
benjirewis added a commit that referenced this pull request May 4, 2022
benjirewis added a commit that referenced this pull request May 4, 2022
benjirewis added a commit that referenced this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants