JAVA-652: Synchronizing on correct object in close method

mongodb · Oct 9, 2012 · e257252 · e257252
1 parent 7c3f31f
commit e257252
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/src/main/com/mongodb/util/SimplePool.java b/src/main/com/mongodb/util/SimplePool.java
@@ -155,14 +155,12 @@ private boolean permitAcquired(final long waitTime) throws InterruptedException
     }
 
     /** Clears the pool of all objects. */
-    protected void close(){
-        synchronized( _avail ){
-            _closed = true;
-            for ( T t : _avail )
-                cleanup( t );
-            _avail.clear();
-            _out.clear();
-        }
+    protected synchronized void close(){
+        _closed = true;
+        for (T t : _avail)
+            cleanup(t);
+        _avail.clear();
+        _out.clear();
     }
 
     public String getName() {