Adding DeleteExactKeyStrategy #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for the Mongo filter opreation to be set to the exact key coming from the key doc rather than having a superfluous _id key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for the Mongo filter opreation to be set to the exact key coming from the key doc rather than having a superfluous _id key.
This is needed for a few use cases I can imagine, but the one in particular is when the key doc is inserting into a sharded collection and already has an _id field with another field and the document.id.strategy is set to PartialValueStrategy for inserts/updates. When deleting, I would like to simply directly set the key (as the key already has the required fields) instead of generating an additional _id key that the DeleteOneDefaultStrategy seems to add:
if (idStrategy instanceof DefaultIdFieldStrategy) { deleteFilter = idStrategy.generateId(document, null).asDocument(); } else { deleteFilter = new BsonDocument(ID_FIELD, idStrategy.generateId(document, null)); }Notice if the ID strategy is anything other than the default ID strategy, the DeleteOneDefaultStrategy adds the
ID_FIELDkey.With this, I can now simply specify the delete.writemodel.strategy as DeleteExactKeyStrategy and it will properly format the filter expression.
I could not find any way to get this behaviour out of the current write strategies.