Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sink validation issue including synthetic config property #47

Merged
merged 1 commit into from Jan 13, 2021

Conversation

rozza
Copy link
Member

@rozza rozza commented Jan 12, 2021

The config definition includes two synthetic properties: The topic override template property and the topic property. When validating these should not be included in the results. This combined with https://issues.apache.org/jira/browse/KAFKA-10600 can
cause confusion to users.

KAFKA-166

@rozza rozza requested review from durran and jyemin January 12, 2021 15:12
@jyemin jyemin self-requested a review January 12, 2021 19:30
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants