This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
Fixed PHP-1505: negative files.length when storing file with size > 2GB in GridFS #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -742,7 +742,7 @@ PHP_METHOD(MongoGridFS, storeFile) | |||
| char *buf; | |||
| zval *chunk_id = NULL; | |||
|
|
|||
| int chunk_size = size-pos >= global_chunk_size || fp == 0 ? global_chunk_size : size-pos; | |||
| long chunk_size = size-pos >= global_chunk_size || fp == 0 ? global_chunk_size : size-pos; | |||
There was a problem hiding this comment.
Any reason not to use unsigned here? Or a more platform-independent type, such as uint64?
There was a problem hiding this comment.
No, but it needs to be done throughout the file. The user also said it didn't quite work for him, so that's why I didn't want to merge it yet either.
|
Superseded by #866. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've not created a test, as it would mean shifting > 2GB around. I've verified it locally.