Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPC-1494: Add client metadata support for wrapping libraries #1114

Merged
merged 2 commits into from Mar 20, 2020

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Mar 11, 2020

https://jira.mongodb.org/browse/PHPC-1494

This adds a new "driver" driver option, which can be used to pass custom driver metadata to be used in the server handshake.

@alcaeus alcaeus self-assigned this Mar 11, 2020
@alcaeus alcaeus requested a review from jmikola March 17, 2020 12:44
php_phongo.c Outdated Show resolved Hide resolved
php_phongo.c Outdated Show resolved Hide resolved
php_phongo.c Outdated Show resolved Hide resolved
php_phongo.c Outdated Show resolved Hide resolved
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit on the defined length constant, but LGTM!

php_phongo.c Outdated Show resolved Hide resolved
@alcaeus alcaeus merged commit e254013 into mongodb:master Mar 20, 2020
@alcaeus alcaeus deleted the phpc-1494 branch March 20, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants