PHPC-2165: Expose server error replies in BulkWriteResult #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
feature/phpc-2165-expose-error-replies
branch
from
11980cb
to
57e52fa
Compare
alcaeus
force-pushed
the
feature/phpc-2165-expose-error-replies
branch
from
57e52fa
to
de878fe
Compare
alcaeus
force-pushed
the
feature/phpc-2165-expose-error-replies
branch
from
de878fe
to
3d52b8d
Compare
jmikola
approved these changes
Dec 1, 2022
| @@ -26,6 +26,8 @@ ZEND_END_ARG_INFO() | |||
|
|
|||
| #define arginfo_class_MongoDB_Driver_WriteResult_getWriteErrors arginfo_class_MongoDB_Driver_WriteResult_getUpsertedIds | |||
|
|
|||
| #define arginfo_class_MongoDB_Driver_WriteResult_getErrorReplies arginfo_class_MongoDB_Driver_WriteResult_getUpsertedIds | |||
There was a problem hiding this comment.
I didn't realize gen_stub.php re-used arginfo definitions but I just came across this code:
/* If there already is an equivalent arginfo structure, only emit a #define */
if ($generatedFuncInfo = findEquivalentFuncInfo($generatedFuncInfos, $funcInfo)) { ... }There was a problem hiding this comment.
Yes, I was occasionally confused by this as well. TBH, I stopped reviewing the generated files and instead review the stubs, relying on CI to catch any outdated arginfo files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-2165
Includes an update to libmongoc 1.24-dev
I only added a simple test for
getErrorRepliesas this will be comprehensively tested by the unified spec tests in PHPLIB.