Upgrade to mongoc-1.3.0-beta0 and libbson-1.3.0-beta0 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverse the logic -- The return value of the check_closed handler is true if the stream is _closed_
| @@ -20,7 +20,7 @@ build_lcov() { | |||
| build_lcov | |||
|
|
|||
| phpize | |||
| ./configure --enable-developer-flags --enable-coverage | |||
| ./configure --enable-developer-flags --enable-coverage CFLAGS="-Wno-type-limits" | |||
There was a problem hiding this comment.
| @@ -1356,10 +1352,8 @@ void php_phongo_cursor_to_zval(zval *retval, php_phongo_cursor_t *cursor) /* {{{ | |||
| _ADD_BOOL(zcursor, is_command); | |||
| _ADD_BOOL(zcursor, sent); | |||
| _ADD_BOOL(zcursor, done); | |||
| _ADD_BOOL(zcursor, failed); | |||
There was a problem hiding this comment.
I don't think this was ever actually used to signal failure, so it was removed
|
I am closing this in favour of #141, as that already had some work done towards the changes in this PR. (You might also want to rename your forked repo from mongo-php-driver-prototype to mongo-php-driver, as I got confused when pulling in the legacy commits while cherry picking your commits :-) ) |
|
I actually confused my self to when I couldn't find my changes on github.com/bjori/mongo-php-driver -- finally figuring it was the legacy driver haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a known memory leak in mongoc, see https://jira.mongodb.org/browse/CDRIVER-1017