Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPC-534: Enable configure without SASL #193

Closed
wants to merge 3 commits into from

Conversation

kaplanlior
Copy link
Contributor

And fix some minor issues.

PHP_ARG_WITH(mongodb-sasl, Build with Cyrus SASL support,
[ --with-mongodb-sasl[=DIR] mongodb: Include Cyrus SASL support], auto, yes)
PHP_ARG_WITH(mongodb-sasl, for Cyrus SASL support,
[ --with-mongodb-sasl[=DIR] mongodb: Include Cyrus SASL support], auto, no)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why you are changing the default from "yes" to "no" here?

@kaplanlior
Copy link
Contributor Author

When the default is yes, it doesn't respect --with-mongodb-sasl=no . The macros keep changing it to yes.
That also makes auto to become yes (and making the other check no relevant).

@jmikola
Copy link
Member

jmikola commented Jan 6, 2016

I can reproduce the behavior @kaplanlior mentioned above. On that note, I think we should make a similar change to --with-pcre-dir[=DIR].

FWIW, this doesn't appear to be discussed directly in the build docs. Their --with-example[=FILE] example would omit the "auto, (yes|no)" bit entirely. For our needs of having --with-mongodb-sasl default to auto if unspecified, but still respect "=no", Lior's solution seems to work nicely.

@jmikola jmikola changed the title Enable configure without SASL PHPC-534: Enable configure without SASL Jan 6, 2016
@jmikola
Copy link
Member

jmikola commented Jan 6, 2016

I rebased this with additional changes (and a link to a corresponding JIRA ticket) in #197.

@jmikola jmikola closed this Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants