PHPLIB-518: Don't assert error codes for pre-3.2 servers in renameCol…

…lection tests
mongodb · Oct 20, 2021 · 88d74b8 · 88d74b8
1 parent 3a0bef4
commit 88d74b8
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/tests/Operation/RenameCollectionFunctionalTest.php b/tests/Operation/RenameCollectionFunctionalTest.php
@@ -107,8 +107,11 @@ public function testRenameCollectionExistingTarget(): void
 
         $this->expectException(CommandException::class);
 
-        // mongos returns an inconsistent error code (see: SERVER-60632)
-        if (! $this->isShardedCluster()) {
+        /* TODO: mongos returns an inconsistent error code (see: SERVER-60632)
+         *
+         * Note: pre-3.2 server versions omit an error code. libmongoc will
+         * substitute MONGOC_ERROR_QUERY_FAILURE in _mongoc_cmd_check_ok. */
+        if (! $this->isShardedCluster() && version_compare($this->getServerVersion(), '3.2.0', '>=')) {
             $this->expectExceptionCode(self::$errorCodeNamespaceExists);
         }
 
@@ -124,7 +127,13 @@ public function testRenameCollectionExistingTarget(): void
     public function testRenameNonexistentCollection(): void
     {
         $this->expectException(CommandException::class);
-        $this->expectExceptionCode(self::$errorCodeNamespaceNotFound);
+
+        /* Note: pre-3.2 server versions omit an error code. libmongoc will
+         * substitute MONGOC_ERROR_QUERY_FAILURE in _mongoc_cmd_check_ok */
+        if (version_compare($this->getServerVersion(), '3.2.0', '>=')) {
+            $this->expectExceptionCode(self::$errorCodeNamespaceNotFound);
+        }
+
         $operation = new RenameCollection(
             $this->getDatabaseName(),
             $this->getCollectionName(),