-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we drop jean85/pretty-package-versions:1.2
?
#1022
Comments
jean85/pretty-package-versions
1jean85/pretty-package-versions:1.2
?
PHPLIB 1.9.0 required PHP 7.1+ (see: composer.json), so I don't think there's any reason to have |
Yes I was being conservative because 1.x supports Composer 1. If you drop 1.x, you drop support for Composer 1; that wasn't doable then, while now is up to you. |
From my POV it is ok to drop support for Composer 1, while were are at Composer 2.5.1 right now. WDYT @alcaeus ? |
Given how long composer 1 has been out of date, I think it should be safe dropping support for it in the next minor version of the library. |
:caution: By merging this PR, the library will not support Composer 1 anymore ❗ closes mongodb#1022
⚠️ By merging this PR, the library will not support Composer 1 anymore ❗ closes mongodb#1022
⚠️ By merging this PR, the library will not support Composer 1 anymore ❗ closes mongodb#1022
⚠️ By merging this PR, the library will not support Composer 1 anymore ❗ closes mongodb#1022
Is there a reason, we support two major versions?
mongo-php-library/composer.json
Line 16 in 49f3e3d
IMHO
1.2
can safely be dropped, as2.0
still supports PHP 7.1:https://github.com/Jean85/pretty-package-versions/blob/ea175e0a262389d59d35802d9e32319fa64449c0/composer.json#L5-L6
The text was updated successfully, but these errors were encountered: