Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we drop jean85/pretty-package-versions:1.2? #1022

Closed
OskarStark opened this issue Dec 23, 2022 · 4 comments · Fixed by #1027
Closed

Can we drop jean85/pretty-package-versions:1.2? #1022

OskarStark opened this issue Dec 23, 2022 · 4 comments · Fixed by #1027

Comments

@OskarStark
Copy link
Contributor

Is there a reason, we support two major versions?

"jean85/pretty-package-versions": "^1.2 || ^2.0.1",

IMHO 1.2 can safely be dropped, as 2.0 still supports PHP 7.1:
https://github.com/Jean85/pretty-package-versions/blob/ea175e0a262389d59d35802d9e32319fa64449c0/composer.json#L5-L6

@OskarStark OskarStark changed the title Drop jean85/pretty-package-versions 1 Can we drop jean85/pretty-package-versions:1.2? Dec 23, 2022
@jmikola
Copy link
Member

jmikola commented Dec 27, 2022

PHPLIB 1.9.0 required PHP 7.1+ (see: composer.json), so I don't think there's any reason to have ^1.2 || in the version field. I expect @Jean85 was just being conservative when opening PRs to add || ^2.0 in various projects (e.g. #805). Feel free to submit a PR to remove ^1.2 || if you like.

@Jean85
Copy link
Contributor

Jean85 commented Dec 27, 2022

Yes I was being conservative because 1.x supports Composer 1.

If you drop 1.x, you drop support for Composer 1; that wasn't doable then, while now is up to you.

@OskarStark
Copy link
Contributor Author

From my POV it is ok to drop support for Composer 1, while were are at Composer 2.5.1 right now.

WDYT @alcaeus ?

@alcaeus
Copy link
Member

alcaeus commented Jan 10, 2023

Given how long composer 1 has been out of date, I think it should be safe dropping support for it in the next minor version of the library.

OskarStark added a commit to OskarStark/mongo-php-library that referenced this issue Jan 10, 2023
:caution: By merging this PR, the library will not support Composer 1 anymore ❗

closes mongodb#1022
OskarStark added a commit to OskarStark/mongo-php-library that referenced this issue Jan 10, 2023
⚠️ By merging this PR, the library will not support Composer 1 anymore ❗

closes mongodb#1022
OskarStark added a commit to OskarStark/mongo-php-library that referenced this issue Jan 10, 2023
⚠️ By merging this PR, the library will not support Composer 1 anymore ❗

closes mongodb#1022
OskarStark added a commit to OskarStark/mongo-php-library that referenced this issue Jan 12, 2023
⚠️ By merging this PR, the library will not support Composer 1 anymore ❗

closes mongodb#1022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants