PHPLIB-1392: Convert transaction tests and support schema 1.9 #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
force-pushed
the
utf-schema-1.9
branch
from
7a37a0a
to
14cbfc7
Compare
jmikola
force-pushed
the
utf-schema-1.9
branch
from
59ca01e
to
bb4ccfc
Compare
jmikola
changed the title
jmikola
force-pushed
the
utf-schema-1.9
branch
from
bb4ccfc
to
200049f
Compare
4 tasks
|
Evergreen failures all seem related to rotating Azure credentials for CSFLE (see also: #1228 (comment)). @alcaeus: please let me know when that's done and I'll rebase. |
jmikola
force-pushed
the
utf-schema-1.9
branch
4 times, most recently
from
e62d4b5
to
388dc59
Compare
alcaeus
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Changes to the unified spec runner look fine. I did not review changes in the individual test files (doing that in the corresponding spec PR).
Confirmed that test failures are due to Azure credentials, but again I didn't check all the builds. We'll have to wait until the new credentials are available.
jmikola
force-pushed
the
utf-schema-1.9
branch
from
388dc59
to
1aa9514
Compare
4 tasks
UnifiedTestRunner::preventStaleDbVersionError() already handles this. The Operation code was likely always redundant and dates back to the original test runner implementation in 4608a73.
See: mongodb#1228 Also updates a reference to a moved JIRA issue
jmikola
force-pushed
the
utf-schema-1.9
branch
2 times, most recently
from
e91893c
to
1a28efa
Compare
jmikola
force-pushed
the
utf-schema-1.9
branch
from
1a28efa
to
744ccb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-1392
https://jira.mongodb.org/browse/PHPLIB-1397
This branch is being used to POC converted unified spec tests in:
Patch build on all topologies and serverless: https://spruce.mongodb.com/version/65cbe6b732f4174551b0143a/tasks
This PR implements the
createEntitiesoperation from UTF schema 1.9, as it was necessary for some spec tests. The following 1.9 schema features have been left unimplemented:createOptionsfield toinitialDatatimeoutMSfield incollectionOrDatabaseOptionsisTimeoutErrorfield toexpectedError