Remove usage of deprecated BSON functions #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I'm surprised the psalm errors showed up again, as they were added to the baseline. It could be an issue of the context (i.e. the actual code triggering it) having changed and GitHub seeing it as a new issue as a result. Either way, I've added an assertion and type hint to the class. |
alcaeus
force-pushed
the
remove-deprecated-phpc-usage
branch
from
986c2b6
to
101bb44
Compare
GromNaN
approved these changes
Jul 16, 2024
tests/Model/BSONIteratorTest.php
Outdated
Comment on lines
32
to
33
| implode(array_map( | ||
| 'MongoDB\BSON\fromPHP', | ||
| fn ($input) => (string) Document::fromPHP($input), |
There was a problem hiding this comment.
This transformation could move to the test method, since it's identical in all data set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of failures due to unexpected deprecation messages after these methods were deprecated in PHPC 1.20