PHPLIB-114: Implement GridFS specification #57
Conversation
|
|
||
| public function stream_write($data) | ||
| { | ||
| echo strlen($data). "\n"; |
jmikola
changed the title
williambanfield
force-pushed
the
PHP-GridFs
branch
from
0e70913
to
56023b0
Compare
williambanfield
force-pushed
the
PHP-GridFs
branch
from
2cc8b96
to
22e0480
Compare
| <?php | ||
| namespace MongoDB\GridFS; | ||
|
|
||
| class BucketReadWriter |
There was a problem hiding this comment.
Let's fold this class and its methods into the Bucket class, since that's where the spec expects to find these methods.
There was a problem hiding this comment.
This class still exists, but is no longer called from anywhere. Just keeping it around until we're sure we're done with it.
PHPLIB-114: CS fixes and refactoring
| * @param array $options Additional options | ||
| * @return Cursor | ||
| */ | ||
| public function find($filter, array $options = []) |
There was a problem hiding this comment.
Per #57 (comment), I think we should default $filter to an empty array.
williambanfield
force-pushed
the
PHP-GridFs
branch
from
391f6af
to
87d08a6
Compare
|
Can't wait for it ;) Good work! |
|
Any benchmarks for performance comparison from this lib to usage with legacy driver grid fs implementation? |
|
@prolic: Not yet. We're certainly aiming to do some before this gets released in 1.1. There is actually a cross-driver benchmark specification that @derickr has started implementing for the old/new drivers, which also includes tests for GridFS operations. I'm currently preoccupied with fixing some PHPC issues (as is @derickr with getting HHVM 1.1.0 released); however, I should be returning to PHPLIB work once PHPC 1.1.3 is released and this is high on my list to merge down and begin cleaning up and benchmarking. |
|
Anything we can do to progress this PR any further? Library doesn't feel complete without GridFS support... |
|
do you have preliminary date, when this PR will be merged? |
|
Manually merged in aef27f0, which is now the |
jmikola
changed the title
https://jira.mongodb.org/browse/PHPLIB-114