Prohibit +/-infinity as timeout values

mongodb · Oct 6, 2012 · 28a7ed9 · 28a7ed9
1 parent 1da312e
commit 28a7ed9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pymongo/common.py b/pymongo/common.py
@@ -93,7 +93,7 @@ def validate_positive_float(option, value):
         value = float(value)
     except (ValueError, TypeError):
         raise err
-    if value <= 0:
+    if not 0 < value < float('inf'):
         raise err
 
     return value

diff --git a/test/test_uri_parser.py b/test/test_uri_parser.py
@@ -84,6 +84,8 @@ def test_split_options(self):
         self.assertRaises(ConfigurationError, split_options, 'socketTimeoutMS=0.0')
         self.assertRaises(ConfigurationError, split_options, 'connectTimeoutMS=foo')
         self.assertRaises(ConfigurationError, split_options, 'connectTimeoutMS=0.0')
+        self.assertRaises(ConfigurationError, split_options, 'connectTimeoutMS=inf')
+        self.assertRaises(ConfigurationError, split_options, 'connectTimeoutMS=-inf')
         self.assertTrue(split_options('socketTimeoutMS=300'))
         self.assertTrue(split_options('connectTimeoutMS=300'))
         self.assertEqual({'sockettimeoutms': 0.3}, split_options('socketTimeoutMS=300'))