Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-4346 Reinstate CODEOWNERS File and Add Static Check in CI #1587

Merged
merged 12 commits into from
Apr 16, 2024

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 marked this pull request as draft April 16, 2024 10:41
@blink1073 blink1073 changed the title PYTHON-4346 Reinstate CODEOWNERS File PYTHON-4346 Reinstate CODEOWNERS File and Add Static Check in CI Apr 16, 2024
Copy link
Contributor

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One question.

@@ -15,13 +15,17 @@ defaults:

jobs:

lint:
static:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the significance of the keyword static here? I couldn't find it via a quick google search.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just the name I'm going to use for "required status checks"

@blink1073 blink1073 marked this pull request as ready for review April 16, 2024 16:01
@blink1073 blink1073 merged commit 09e24a4 into mongodb:master Apr 16, 2024
21 of 23 checks passed
@blink1073 blink1073 deleted the PYTHON-4346 branch April 16, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants