PYTHON-4451 Use Hatch as Build Backend #1644
Conversation
blink1073
changed the title
|
I filed PYTHON-4452 for the libmongocrypt failure. |
|
evergreen retry |
| @@ -136,32 +136,8 @@ def build_extension(self, ext): | |||
| ) | |||
| ext_modules = [] | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
You were able to get rid of all this because of the way that requirements.txt is handled? That's awesome!
| @@ -31,12 +31,10 @@ jobs: | |||
| - name: Run linters | |||
| run: | | |||
| tox -m lint-manual | |||
| - name: Check Manifest | |||
There was a problem hiding this comment.
I read the Why Hatch? page. I'm starting to get it. Very nice.
pymongo/_version.py
Outdated
| if isinstance(version_tuple[-1], str): | ||
| return ".".join(map(str, version_tuple[:-1])) + version_tuple[-1] | ||
| return ".".join(map(str, version_tuple)) | ||
| pattern = r"(?P<major>\d+).(?P<minor>\d+).(?P<patch>\d+)(?P<rest>.*)" |
There was a problem hiding this comment.
Can we make this a function and add a few unit tests to make sure it works with a variety of versions? Eg "4.8.0.dev1", "4.8.0", "5.0", etc...
There was a problem hiding this comment.
Done. We don't support "5.0", it has to have the patch version.
There was a problem hiding this comment.
I think not supporting "5.0" is a mistake. Our 4.0 release used "4.0" for example, same for "3.0". If we don't support "5.0" then I worry we'll accidentally set the version to a 2 part at some point and lead to a bug where version_tuple is silently set to an empty tuple.
(cherry picked from commit 2b03001)
(cherry picked from commit 2b03001)
No description provided.