Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUST-734 Sharded Transactions #408

Merged
merged 3 commits into from
Aug 2, 2021
Merged

RUST-734 Sharded Transactions #408

merged 3 commits into from
Aug 2, 2021

Conversation

NBSquare
Copy link
Contributor

This is the final PR to implement sharded transactions. The first two commits have already gone through the review process, and the third commit wraps up some loose ends surrounding documentation, testing, etc. So, that third commit is the most relevant one to look at IMO.

Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one small suggestion

src/concern/test.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great work on this! tagging in the rest of the team

Copy link
Contributor

@patrickfreed patrickfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the Python file used to generate the transaction spec tests? Other than that LGTM!

Copy link
Contributor

@patrickfreed patrickfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NBSquare NBSquare merged commit 8edbf66 into master Aug 2, 2021
@NBSquare NBSquare deleted the sharded-transactions branch August 2, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants