RUST-993 Implement Clone for Collection<T> #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awitten1
changed the title
patrickfreed
approved these changes
Sep 8, 2021
|
Once this PR is ready to merge, just hit the "Squash and Merge" button and make sure the commit title matches the PR title (i.e. includes ticket number and brief description). |
awitten1
added a commit
to awitten1/mongo-rust-driver
that referenced
this pull request
Sep 9, 2021
Because derive is too conservative, derive only implements Clone for Collection<T> if T is Clone. Collection<T> does not actually store any value of type T (so T does not need to be Clone).
awitten1
added a commit
to awitten1/mongo-rust-driver
that referenced
this pull request
Sep 9, 2021
Because derive is too conservative, derive only implements Clone for Collection<T> if T is Clone. Collection<T> does not actually store any value of type T (so T does not need to be Clone).
awitten1
added a commit
to awitten1/mongo-rust-driver
that referenced
this pull request
Sep 21, 2021
Because derive is too conservative, derive only implements Clone for Collection<T> if T is Clone. Collection<T> does not actually store any value of type T (so T does not need to be Clone).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
deriveis too conservative,deriveonly implements Clone forCollection<T>if T is Clone.Collection<T>does not actually store any value of type T (so T does not need to be Clone).