Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUST-892 implement FromStr for ServerAddress #458

Merged
merged 3 commits into from Sep 10, 2021
Merged

RUST-892 implement FromStr for ServerAddress #458

merged 3 commits into from Sep 10, 2021

Conversation

awitten1
Copy link
Contributor

@awitten1 awitten1 commented Sep 9, 2021

Implement FromStr for ServerAddress. Allows for calling "a:1234".parse() (this requires type annotations or turbofish syntax).

isabelatkinson
isabelatkinson reviewed Sep 9, 2021
View reviewed changes
Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, can we also add a test to ensure the implementation functions properly? There's a test module at the bottom of src/client/options/mod.rs that we can add it to.

@awitten1 awitten1 merged commit c8657b1 into mongodb:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickfreed patrickfreed patrickfreed approved these changes

@abr-egn abr-egn abr-egn approved these changes

@isabelatkinson isabelatkinson isabelatkinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@awitten1 @patrickfreed @abr-egn @isabelatkinson