RUST-1046 Fix iteration of cursors when batchSize doesn't divide result size #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
commented
Oct 8, 2021
| @@ -61,7 +61,6 @@ pub struct SessionCursor<T> | |||
| where | |||
| T: DeserializeOwned + Unpin, | |||
| { | |||
| exhausted: bool, | |||
There was a problem hiding this comment.
the issue here is that the GenericCursor created in stream was using the info.id field to determine if the cursor was exhausted rather than this exhausted field, which would cause it to iterate past the end and return an error. This was fixed by using info.id as the single source of truth as to whether the SessionCursor is exhausted or not.
abr-egn
approved these changes
Oct 11, 2021
isabelatkinson
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1046 (fixes #482)
This PR fixes a bug in
SessionCursorwhere iterating it withnext()would always eventually result in an error if the result count wasn't divisible by the batchSize.