RUST-1048 add default_database api for client #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
approved these changes
Oct 26, 2021
|
is there any way to look into why CI failed? |
isabelatkinson
approved these changes
Oct 27, 2021
|
It looks like The other failures look to be some unrelated known flaky tests, so nothing to worry about there. |
abr-egn
approved these changes
Oct 27, 2021
|
Ok, I've fix typo and make a rebase, it should be formatted.. |
|
Thanks again for your contribution @WindSoilder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #475
Regarding to this:
Personally, I think make
default_database(&self)returned anOption<Database>is easiler to use. And the behavior is more matches for the function name.If user want to get default database name, we can get it from
ClientOptions.default_database, or using something likeclient.default_database().unwrap().name().Maybe something is missing, any review suggestion is appreciated :-)