RUST-537 Aggregation, runCommand, and index management examples #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| use crate::{error::Result, Database}; | ||
|
|
||
| pub(crate) async fn populate(db: &Database) -> Result<()> { | ||
| fn iso_date(text: &str) -> bson::DateTime { |
There was a problem hiding this comment.
Can we update this to return a result rather than unwrapping? Also, we should consider waiting til RUST-977 is merged so that we can use the method implemented there rather than going through chrono.
There was a problem hiding this comment.
Updated to use parse_rfc3339_str.
patrickfreed
reviewed
Nov 8, 2021
patrickfreed
approved these changes
Nov 8, 2021
|
Oh it looks like lint broke with the latest changes, so once thats fixed LGTM (no need for me to review again). |
isabelatkinson
approved these changes
Nov 8, 2021
abr-egn
force-pushed
the
RUST-537/agg-run-index-examples
branch
from
c953c47
to
d908104
Compare
abr-egn
force-pushed
the
RUST-537/agg-run-index-examples
branch
from
d908104
to
c1bae79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.