WIP: Introduce operation concept and client pool #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we have a generic method for executing things that conform to the `Operation` protocol. This allows us to do many interesting things, most notably pop clients off a pool and use them for operation execution.
A few things going on here. First, a new type `MongoNamespace` was introduced to make it easy to track the current namespace without needing to necessarily pass collections or databases around. Secondly, execution is now passed a pointer to the `mongoc_client_t` so that we can create the `mongoc_collection_t` or `mongoc_database_t` at the moment of execution, this allows us to avoid most of the pitfalls of lack of thread safety in libmongoc.
This changes introduces a client pool into the `MongoClient` ctor. Of note is that the pool is currently only used for two operations which have been converted to `Operation` subclasses (insertOne, updateOne), and it maintains behavior for all other operations by popping a client at init, and pushing it back before close.
jmikola
reviewed
Apr 1, 2019
|
is it possible to convert this to a draft, or can it not be reversed once it's "ready for review"? |
|
I tried to convert it to a draft, but couldn’t find an easy way to do so.
I’ll just close the PR, you can look at the branch
…On Tue, Apr 2, 2019 at 6:33 PM Kaitlin Mahar ***@***.***> wrote:
is it possible to convert this to a draft, or can it not be reversed once
it's "ready for review"?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#219 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AATGhg4vJqMZnqj22ojlDKU3WTUp3gw0ks5vc9rTgaJpZM4b5tjN>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set introduces a concept of an "operation" to our codebase, allowing us to abstract calls to libmongoc in order to do things like use a client pool, or asynchronously run the operation on a thread pool. I threw in the client pool to show how it can be used, maintaining existing behavior by reserving one client from the pool for things that haven't been converted to operations yet.