SWIFT-276: Swift 5 support #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroadst
force-pushed
the
SWIFT-276/build-with-swift-5
branch
from
e41f2e2
to
e48666a
Compare
kmahar
suggested changes
Apr 9, 2019
patrickfreed
reviewed
Apr 9, 2019
mbroadst
force-pushed
the
SWIFT-276/build-with-swift-5
branch
2 times, most recently
from
0f655e8
to
40afed7
Compare
patrickfreed
approved these changes
Apr 10, 2019
kmahar
approved these changes
Apr 10, 2019
| fatalError("Failed to initialize an iterator over document \(self)") | ||
| } | ||
|
|
||
| for pos in 0..<position + 1 { |
There was a problem hiding this comment.
nit: maybe clearer to just write this as for pos in 0...position?
There was a problem hiding this comment.
oh yeah duh, silly copy pasta on my part there!
This adds support for compiler(>=5.0)
JSONSerialization changed how they serialized JSON between v4 and v5, so we'll use libbson for JSON cleaning for now.
mbroadst
force-pushed
the
SWIFT-276/build-with-swift-5
branch
from
40afed7
to
e28a2af
Compare
mbroadst
force-pushed
the
SWIFT-276/build-with-swift-5
branch
from
e28a2af
to
036e76e
Compare
|
That's great, amazing job 👍🏻 |
|
@valeriomazzeo yup, within the next few days 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces full support for Swift 5 on OSX and Linux.