SWIFT-1168 Vendor libmongoc 1.18.0-alpha #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
commented
Apr 9, 2021
| @@ -1,5 +1,5 @@ | |||
| diff --git a/Sources/CLibMongoC/include/CLibMongoC_mongoc-client-pool.h b/Sources/CLibMongoC/include/CLibMongoC_mongoc-client-pool.h | |||
| index 16d7eb1..bcf1cde 100644 | |||
| index 16d7eb1a..bcf1cdee 100644 | |||
There was a problem hiding this comment.
this patch needed to be regenerated due to changes in mongoc-client-pool.{h, c}
kmahar
changed the title
patrickfreed
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendors in libmongoc's 1.18.0 alpha.
In my patch I encountered some random timeout errors in various tests where we were using maxTimeMS on macOS.... Some of these tests I see also failing occasionally prior to the upgrade on the waterfall.
The maxTimeMS value choices seemed arbitrary in all of these tests so I just increased them in an attempt to make them less flaky. In any case, since maxTimeMS is purely a server-side option I don't think this has anything to do with the upgrade.