SWIFT-1347 Fix memory leak in tests caused by ClientSession.pinnedServerAddress #675
Conversation
| @@ -94,8 +94,11 @@ public final class ClientSession { | |||
| return nil | |||
| } | |||
| return connection.withMongocConnection { client in | |||
| let serverDescription = | |||
| ServerDescription(mongoc_client_get_server_description(client, serverID)) | |||
| guard let sd = mongoc_client_get_server_description(client, serverID) else { | |||
There was a problem hiding this comment.
I don't fully understand why, but if the result of mongoc_client_get_server_description is passed directly into the ServerDescription initializer it doesn't need to be unwrapped. But if I assign it to a variable like this then I have to unwrap it to be able to pass it in.
This evolution proposal explains why the pointer is optional in the first place, and makes sense, but it doesn't make much sense to me that it gets coerced into a non-optional by passing it directly to the initializer... 🤷♀️
There was a problem hiding this comment.
Huh, yeah not sure what's going on there either.
| @@ -94,8 +94,11 @@ public final class ClientSession { | |||
| return nil | |||
| } | |||
| return connection.withMongocConnection { client in | |||
| let serverDescription = | |||
| ServerDescription(mongoc_client_get_server_description(client, serverID)) | |||
| guard let sd = mongoc_client_get_server_description(client, serverID) else { | |||
There was a problem hiding this comment.
Huh, yeah not sure what's going on there either.
|
(test failure is an unrelated issue caused by a server change, see my message in driver-devs) |
As discovered via adding
leaksto CI in my other PR. After this gets merged in I will rebase over there to get the new tasks passing.