Fix mongorestore --oplogReplay #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `mongorestore` with the `--oplogReplay` command line option was failing when the `dump/oplog.bson` file was larger than 16MB.
|
Rafael, Thank you for filing this issue, and very sorry you were hit by this. We appreciate that you put up a pull request to bring this to our attention. There is a tracking ticket for the issue on our Jira here: https://jira.mongodb.org/browse/TOOLS-754 In order to push a fix for a bug like this, it was essential for us to have a comprehensive integration test to confirm a fix against. Using this report, I was able to create one and then fix the issue. I've just deployed those changes to the Thank you again for alerting us to this issue. |
|
You're welcome. Thanks for reviewing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
mongorestorewith the--oplogReplaycommand line option fails if thedump/oplog.bsonfile is larger than 16MB. It prints the following error message.I think the problem is on line 17 of mongorestore/oplog.go. The
oplogMaxCommandSizeconstant is defined as 16.5 MB, even though the MongoDB maximum document size is 16 MB!?! This causes an exception on the server side which closes theapplyOpscommand cursor, hence the EOF message.I'm not sure why, but setting
oplogMaxCommandSizeto1024 * 1024 * 16did not fix the problem for me. But setting it to1024 * 1024 * 15made the bug go away.There is also a report of this bug on StackOverflow.