Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOOLS-2956 Use new macOS notarization service to sign macOS release #477

Merged
merged 3 commits into from Oct 18, 2022
Merged

TOOLS-2956 Use new macOS notarization service to sign macOS release #477

merged 3 commits into from Oct 18, 2022

Conversation

autarch
Copy link
Contributor

@autarch autarch commented Oct 14, 2022

No description provided.

@autarch autarch changed the base branch from master to TOOLS-3185 October 14, 2022 20:23
@autarch autarch requested a review from tfogo October 17, 2022 15:54
tfogo
tfogo reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@tfogo tfogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a successful run of this on evg I can check?

@autarch
Copy link
Contributor Author

autarch commented Oct 18, 2022

Is there a successful run of this on evg I can check?

See https://spruce.mongodb.com/version/6349c354e3c33136312b2d94/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

@autarch autarch requested a review from tfogo October 18, 2022 18:58
tfogo
tfogo approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@tfogo tfogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the same note about the lss as the mongosync PR.

@autarch autarch merged commit e33b3ad into TOOLS-3185 Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfogo tfogo tfogo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@autarch @tfogo