TOOLS-3411 Fix issue where sort order of views was not always preserved on dump #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jddubois
changed the title
tdq45gj
reviewed
Nov 7, 2023
| {Key: "score", Value: 1}, | ||
| }}}, | ||
| } | ||
|
|
There was a problem hiding this comment.
Given that the original bug of reordering is probabilistic, can we shuffle the pipeline in this test to test different orderings?
There was a problem hiding this comment.
I think we can make the test reliably fail when there is an issue by just running the body of the test in a loop, which might be a bit easier than trying to shuffle the bson? What do you think about that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
mongodumpdid not always preserve the order of options for a view or collection. This could result in different sort orders than expected on views. It is easily fixed by moving from the unorderedbson.Mtype to the orderedbson.Dtype for collection options. Index options are still abson.M, but the keys arebson.Dso they are not affected by this issue.I tested manually by viewing the metadata JSON files produced by
mongodumpon both this branch and master. I also verified that the added test succeeds every time on this branch, but fails most of the time on master.