Skip to content

Commit

Permalink
SERVER-4729: log slow queries + improved test
Browse files Browse the repository at this point in the history
  • Loading branch information
Brandon Diamond committed Feb 9, 2012
1 parent 7fd5cf7 commit 19bf4db
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 0 deletions.
41 changes: 41 additions & 0 deletions jstests/getlog2.js
@@ -0,0 +1,41 @@
// tests getlog as well as slow querying logging

glcol = db.getLogTest2;
glcol.drop()

contains = function(arr, func) {
var i = arr.length;
while (i--) {
if (func(arr[i])) {
return true;
}
}
return false;
}

// test doesn't work when talking to mongos
if(db.isMaster().msg != "isdbgrid") {
// run a slow query
glcol.save({ "SENTINEL": 1 });
glcol.findOne({ "SENTINEL": 1, "$where": function() { sleep(1000); return true; } });

// run a slow update
glcol.update({ "SENTINEL": 1, "$where": function() { sleep(1000); return true; } }, { "x": "x" });

var resp = db.adminCommand({getLog:"global"});
assert( resp.ok == 1, "error executing getLog command" );
assert( resp.log, "no log field" );
assert( resp.log.length > 0 , "no log lines" );

// ensure that slow query is logged in detail
assert( contains(resp.log, function(v) {
print(v);
return v.indexOf(" query ") != -1 && v.indexOf("query:") != -1 && v.indexOf("SENTINEL") != -1;
}) );

// same, but for update
assert( contains(resp.log, function(v) {
print(v);
return v.indexOf(" update ") != -1 && v.indexOf("query:") != -1 && v.indexOf("SENTINEL") != -1;
}) );
}
1 change: 1 addition & 0 deletions src/mongo/db/ops/query.cpp
Expand Up @@ -662,6 +662,7 @@ namespace mongo {

curop.debug().ns = ns;
curop.debug().ntoreturn = pq.getNumToReturn();
curop.debug().query = jsobj;
curop.setQuery(jsobj);

if ( pq.couldBeCommand() ) {
Expand Down

0 comments on commit 19bf4db

Please sign in to comment.