CLOUDP-65729: Add sharded cluster support to Ops Manager #217
Conversation
| in.Processes = append(in.Processes[:k], in.Processes[k+1:]...) | ||
| out[i].ProcessConfigs[j] = newReplicaSetProcessConfig(m, p) | ||
| out[i].addToMongoURI(p) | ||
| in.Processes = removeProcess(in.Processes, k) |
There was a problem hiding this comment.
Is there a reason to modify the in argument?
There was a problem hiding this comment.
since this is such a complex search (O(n*m*o)) I'm trying to speed up search by deleting visited processes
I want at some point benchmark this to see how else can we improve it
There was a problem hiding this comment.
I changed the name from in and added a comment about how this method is dangerous
|
|
||
| if constrain.Check(ver) { | ||
| return zero, nil | ||
| func patchSharding(out *opsmngr.AutomationConfig, s *opsmngr.ShardingConfig) { |
There was a problem hiding this comment.
So this doesn't modify existing sharding configs -- is that not supported? Might be worth putting a comment for the function
There was a problem hiding this comment.
I just didn't want to add test for this and manual test takes all my resources, I've added a TODO with a CLOUDP to test it later
internal/convert/rs_config.go
Outdated
|
|
||
| type patcher func(*ProcessConfig, string) *opsmngr.Process | ||
|
|
||
| // path is a generic replica set patcher, you'll need to provide a function that |
There was a problem hiding this comment.
[np] missing rest of comment
There was a problem hiding this comment.
not only that the method name had a typo, fixed
Proposed changes
Jira ticket: CLOUDP-65729
Checklist
make fmtand formatted my codeFurther comments
This adds support to list and create sharded clusters, update is still untested
Open to suggestion on naming specially of
RSConfigstruct