Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-130483: Fixed diskSizeGB decreasing #634

Merged
merged 6 commits into from Aug 12, 2022

Conversation

igor-karpukhin
Copy link
Collaborator

@igor-karpukhin igor-karpukhin commented Aug 6, 2022

All Submissions:

Fixed a case when disc size couldn't be decreased if autoscaling is enabled

@@ -133,10 +133,6 @@ func removeOutdatedFields(removeFrom *mongodbatlas.Cluster, lookAt *mongodbatlas
} else {
result.ProviderSettings.AutoScaling.Compute = &mongodbatlas.Compute{}
}

if lookAt.AutoScaling.DiskGBEnabled != nil && *lookAt.AutoScaling.DiskGBEnabled {
Copy link
Contributor

@yzdann yzdann Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @igor-karpukhin,
Are you changing the whole concept of the operator should not touch disk/instance size if autoscaling is enabled? (#322)

For example, we have a deploymentA(Kubernetes object) with a 10GB disk, and disk autoscaling is enabled.
After some time, autoscaler on the Atlas platform decided to increase the disk size to 15GB, the increasing process is finished and now our atlas cluster has a 15GB disk.
What value should we expect in the Kubernetes object related to that deploymentA 10GB or 15GB?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API technically allows disk size to be configured with autoscaling enabled. But, I just revert it to the previous state so it's not configurable if the autoscaling is enabled.

@yzdann
Copy link
Contributor

yzdann commented Aug 9, 2022

resolve: #611

Copy link
Contributor

@fabritsius fabritsius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great 👍

@igor-karpukhin igor-karpukhin merged commit 85b9dcf into main Aug 12, 2022
@igor-karpukhin igor-karpukhin deleted the CLOUDP-130483/cluster-size-decrease branch August 12, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decreasing the Cluster disk size integration test logic doesn't seem right
4 participants